All Jobs Damage Simulator And Gear Sets

Noticing some weird behavior. When trying to use the DPS simulation, it will at times print out an extremely low value for white damage. All of the other numbers looks correct. I've seen it happen several times on different jobs. Here's an example on DRG, showing only ~300 DMG per hit with a T5 Prime:





Am I missing something here? Did I input a wrong setting somewhere, or is this a bug?

Edit: After a little bit more testing, this seems to be related to the Geomancy settings. I get the expected results if I lower GEO Potency down to 90 or less - any higher and the white damage numbers break again. Also seems to happen when I fiddle with Dia/Light Shot settings. Looks like there might be some kind of overflow or rounding error when considering DEF down effects (division by 0 somewhere?).

Show the simulate tab as that is the gear sets used when you simulate, not what you input on the quicklook page.

Thanks for the details. I believe the issue was that I never enforced "enemy_defense > 0" in the "actions.py:average_attack_round()" function (for TP simulations). This was handled in the "weaponskill_info.py" file for weapon skills, so weapon skills were unaffected.

For your DRG/SAM example: all of your debuffs would lower the enemy's defense by about 105.7%, down to -83 defense, which would be passed into the functions for TP damage calculations. The 90-91% geomancy potency was coincidentally the threshold to exceed 100% defense lost. After the fix, the "Average Dmg/Attack" for TP phase in your given TP set changes from ~300 damage to ~6800 damage.

I've updated the GitHub code to fix this issue. Let me know if you find any other bugs.