|
Battlemod v2
Valefor.Omnys
Server: Valefor
Game: FFXI
Posts: 1,759
By Valefor.Omnys 2013-04-23 14:47:01
Same two errors started spamming me halfway through a besieged. Everything was fine and then consistently incoming.
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6,348
By Lakshmi.Byrth 2013-04-23 14:52:05
Thanks, last description helped me figure it out. My abil_ID variable wasn't getting re-initialized, so it was being treated as a global variable. This meant that every time someone used Gauge near you, it would keep trying to make the gauge output message every time anyone hit anything (until the next ability use).
By Ophannus 2013-04-23 14:57:50
Hey just wondering Byrth, which filter includes such things as "Received the effect of XXX" When I'm solo and someone next to me uses Berserk, I still see the "X's attack is enhanced and defense is lowered". Also do you think there will be a way in the future for battlemod to one day be compatible with kparser? I've found myself having to unload it for certain things I parse because kparse can't translate the new log.
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6,348
By Lakshmi.Byrth 2013-04-23 15:05:24
Does Kparser not work with it the way it is now? I've noticed that my log files include both sets of text, but I haven't actually tried to parse anything recently.
I'll add a "status change" filter to the list of things to do. The short-term solution is to filter all things that target "others" though.
By Ophannus 2013-04-23 15:23:02
Kparser doesn't seem to work with battlemod. I believe Kparse parses the log and not packets and due to battlemod intercepting and rewriting the text in the log, Kparse is incompatible with battlemod's log modification.
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6,348
By Lakshmi.Byrth 2013-04-23 15:31:19
Yes, but when I check my logs:
Quote: [20:10:57]SPECIALCODEx1F>þ[÷FaithfulFalcorr] 182 Hit ¨ SPECIALCODEx1F>EGoblin Replica
[20:10:59]FaithfulFalcorr hits the Goblin Replica for 182 points of damage.
The first one is battlemod and the second one is the real message. Both appear in the logs, but only one appears in game. Have you checked it recently?
By segfaultvicta 2013-04-23 22:26:07
Getting the error at line 183: attempt to concatenate local 'effect_val' and 'ability', it seems to be happening when people cast or receive the effect of Blink.
This plugin is amazing by the way and you are my goddamn hero. <3
[+]
Server: Shiva
Game: FFXI
Posts: 27,982
By Shiva.Spathaian 2013-04-23 22:38:38
Getting the error at line 183: attempt to concatenate local 'effect_val' and 'ability', it seems to be happening when people cast or receive the effect of Blink.
This plugin is amazing by the way and you are my goddamn hero. <3 This.
Picture of the error in case it helps and because I already went through the trouble to upload it. :<
Edit: Same error just came up for a friend using Haste Samba.
Edit2: Nevermind... not Haste Samba. Something he did on DNC caused a another error though. I'll see if I can figure it out.
Server: Asura
Game: FFXI
Posts: 256
By Asura.Backstab 2013-04-24 06:45:38
getting an error on line 303 pretty much every few seconds, i cant figure out what triggers it tho.
attempt to call global 't' (a nil value)
edit: only getting the error now if i get a TH proc, earlier when i was getting the error nonstop there was someone in the party that had an enspell active, i assume that was the reason for the errors.
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6,348
By Lakshmi.Byrth 2013-04-24 07:31:25
Thanks guys. I think these problems should be fixed now. You may need to run the launcher once or twice to get an updated version of battlemod. Please let me know if you see them again.
If you want, you can run the launcher (while still logged in) and then do "//lua r battlemod" in game, which will reload the addon and probably give you the most up-to-date version.
Server: Asura
Game: FFXI
Posts: 256
By Asura.Backstab 2013-04-24 10:42:55
not getting any errors so far^^ really great work.
By Yinx 2013-04-24 12:29:13
Getting errors 302 when added effect procs. This is with Mandau and Apoc in case it matters. I think i got the error earlier already when running by someone with enspell, so it's probably just any added effect.
Thanks~
EDIT:
\addons\battlemod\event_action.lua:302: attempt to call global 't' (a nil value)
EDIT again:
Nvm me, im a retard, works perfectly so far after updating the event_action.lua
Thanks so much
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6,348
By Lakshmi.Byrth 2013-04-24 12:35:25
Reload it. I fixed that error this morning.
By Yinx 2013-04-24 12:53:52
Done, and working. ;o
Trick Attack shows as
[Yinx] -> Yinx
Haven't experienced this with any other JA so far.
Sorry for being a nag. D:
Ragnarok.Zirael
Server: Ragnarok
Game: FFXI
Posts: 95
By Ragnarok.Zirael 2013-04-24 13:12:41
Done, and working. ;o
Trick Attack shows as
[Yinx] -> Yinx
Haven't experienced this with any other JA so far.
Sorry for being a nag. D: I've reported this already, Byrth is aware of the issue.
Trick Attack, Elemental Seal and Divine Seal are still not showing.
Leviathan.Arcon
VIP
Server: Leviathan
Game: FFXI
Posts: 682
By Leviathan.Arcon 2013-04-24 18:02:28
It seems Trick Attack and a select (very) few JA have their unique message IDs, for whatever reason. That may be the reason for this.
Valefor.Omnys
Server: Valefor
Game: FFXI
Posts: 1,759
By Valefor.Omnys 2013-04-24 19:15:13
Sending a tell, it only shows the line "... The recipient is offline or changing areas." once.
It probably should display that each time.
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6,348
By Lakshmi.Byrth 2013-04-24 21:37:08
I fixed the trick attack/divine seal/elemental seal thing. I have not fixed the "offline or changing areas" thing yet. I still have to figure out how I'm even blocking it.
Edit: Nevermind, that is fixed too.
Ragnarok.Zirael
Server: Ragnarok
Game: FFXI
Posts: 95
By Ragnarok.Zirael 2013-04-26 01:59:23
Is showing AoE damage (Aeolian Edge, Blizara etc) only on the primary target, instead of all the enemies hit, an intended feature?
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6,348
By Lakshmi.Byrth 2013-04-26 06:54:51
Nope! It's also apparently not showing Iron Giant-esque attacks. I have to give a talk today, so I will try to fix it tomorrow.
By Yinx 2013-04-26 11:26:01
\\addons\battlemod\event_action.lua:140: attempt to concatenate field 'enl' (a nil value)
upon succesfully stealing a Bone Chip.
No message appears in chatlog whatsoever. Ty~
Ragnarok.Zirael
Server: Ragnarok
Game: FFXI
Posts: 95
By Ragnarok.Zirael 2013-04-26 12:15:46
Nope! It's also apparently not showing Iron Giant-esque attacks. I have to give a talk today, so I will try to fix it tomorrow. If that helps, AoE damage from spells and WS's was working fine this Tuesday-Wednesday or so, was broken on Thursday evening (EU).
Good luck with the talk, hope you'll impress some cute chicks ^^/
Edit: How about condensing AoE damage in the same way as buffs? Either one enemy name with all the damages done to that enemy in one line, or a sum of all the damage done to that enemy name? Or a settings toggle allowing people to choose one of three modes. Obviously, if it's too much work and you got better things to do, don't bother!
Something like:
Player AoE 644, 644, 644, 322, 644 Fell Cleave -> [5] Crapaudy
or
Player AoE 2898 Fell Cleave -> [5] Crapaudy
Asura.Fondue
Server: Asura
Game: FFXI
Posts: 2,446
By Asura.Fondue 2013-04-27 12:03:20
any way to get it to show if a mob is stunned with blu spells?
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6,348
By Lakshmi.Byrth 2013-04-27 12:25:09
Yeah. What is the normal log message for a successful BLU spell? My BLU is level 1.
Re: Zirael. I'm trying to work through and fix all the problems you've mentioned as well as add the damage condensation. This is already partially implemented but has some issues. You can put <condensedamage>true</condensedamage> into your settings.xml if you want to try out the current version.
Ragnarok.Martel
Server: Ragnarok
Game: FFXI
Posts: 3,028
By Ragnarok.Martel 2013-04-27 12:38:23
In the case of physical spells like head butt or sudden lunge, it'd just be the usual damage msg. Can you see if an add effect with no msg normally lands?
Martel casts Head Butt.
The Blanched Mandragora takes 53 points of damage.
Is there a packet that'd tell you if an add effect landed? Making those visible would be pretty neat.
Lakshmi.Byrth
VIP
Server: Lakshmi
Game: FFXI
Posts: 6,348
By Lakshmi.Byrth 2013-04-27 12:40:17
Unless the animation or monster reaction is different between successful and unsuccessful stuns, it is pretty unlikely that I can.
Ragnarok.Martel
Server: Ragnarok
Game: FFXI
Posts: 3,028
By Ragnarok.Martel 2013-04-27 12:43:02
I don't think the headbutt animation varies. As for the mob, well, they stop for a sec, but I doubt that's a special packet.
Asura.Fondue
Server: Asura
Game: FFXI
Posts: 2,446
By Asura.Fondue 2013-04-27 12:59:51
I thought it added "and is stunned" after the damage message? I would see ingame but everytime i get near a reive my windower is freezing <.>
Server: Asura
Game: FFXI
Posts: 2,006
By Asura.Lokimaru 2013-04-27 13:01:22
It doesn't add "is stunned", unfortunately.
When a mob is successfully stunned with Head Butt or Sudden Lunge, they kind of jolt back a little. If the stun doesn't land, they just knockback like 4 yalms and continuing attacking as normal.
When the spell misses entirely, nothing happens. :p
Valefor.Omnys
Server: Valefor
Game: FFXI
Posts: 1,759
By Valefor.Omnys 2013-04-27 15:17:05
Two questions.
Can battlemod change the color of "The enemy is no longer paralyzed/blinded/silenced/addled"
Does se only broadcast this effect wearing off message to the caster, or does it send it to the whole alliance and it is only the caster whose log shows it?
OH GOD! I CAN SEE FOREVER! - You need to change your filters (battlemod/data/filters/filter-<job>.xml). I have intentionally set it up so that the default filters are all-off because I figure it's worse if you miss messages that you were expecting than if you see things you weren't expecting. See the "Settings Files" part of the Readme below.
In anticipation of a lot of people having problems with this, I have made this thread to answer questions. First, here is the Readme file:
Readme said: Author: Byrth
Version: 2.0
Date: 13/4/13
Battlemod, packet version
Abbreviation: //bm
Commands:
* help - shows a menu of these commands in game
* colortest - Shows the 509 possible colors for use with the settings file
* reload - Reloads the settings file
* unload - unloads Battlemod
* condensebuffs - Condenses Area of Effect buffs, Default = True
* condensebattle - Condenses battle logs according to your settings file, Default = True
* cancelmulti - Cancles multiple consecutive identical lines, Default = True
* oxford - Toggle use of oxford comma, Default = True
* commamode - Toggle comma-only mode, Default = False
* targetnumber - Toggle target number display, Default = True
* colorful - Colors the output by alliance member, Default = True
Purpose: To allow chat log customization.
Installation Instructions (from the Windower 4 Launcher):
* 1 Start your copy of Windower 4 and select the "Addons" menu up top in the Launcher.
* 2 Click the icon next to "Battlemod"
* 3 Log in to the game!
* 4 Alter the settings as you wish. ("//bm colortest" will let you see the color options and )
* 5 If you have changed the settings, you can use "//bm reload" to load them in game.
Settings Files:
The settings files for battlemod are composed of 3 to 25 xml files (depending on how much you like unique filters). XML files can be opened with Notepad, edited, and saved. If you are going to "Save As..." an xml from Notepad, be sure to change "Text Documents (.txt)" to "All Files" file type and make sure the file ends in ".xml"
* data/settings.xml - contains basic flags that control the features of the program.
* data/colors.xml - contains all the color codes relevant to the program, which can be adjusted using colors from the colortext command.
* filters/filters.xml - contains the chat filter settings and is explained more thoroughly therein.
* filters/filters-<job>.xml - Several examples are provided, but these are specific filter files that will load for your individual jobs. You can use this to, for instance, make sure your healing jobs can always see damage taken (by unfiltering the <monsters></monsters> section or make sure your zerg jobs don't have to see the entire alliance's damage spam.
Known Issues:
* Counters, Spikes, and Retaliations are the wrong color for some reason.
* The "__damage" colors don't do anything, but have been left in the settings file for potential future uses.
* Using //bm colortest and then expanding your chat log on small window size clients (640x480) can cause crashes. (Your guess is as good as mine)
* AoE buffs only use the first message response, so if it has no effect on the user then it will appear to have no effect on everyone even if it did.
* The settings files are much larger and more complicated than v1. (Sorry, it's because there's more options)
* This plugin bypasses and renders invalid all chat filters other than its own.
Secondly, Battlemod attempts to re-create every interaction message (event_action) and other battle messages (event_action_message). I have been testing it for two weeks, but I have not done everything and (more importantly) I do not use every job. There are three major probable and unknown errors:
1) Battle text is showing up as say-color. - This means that I did not see the message while testing battlemod.
2) I'm blocking a message that should display. - This could be anything from your Time remaining in Dynamis to your Mandau's Enpoison effect.
3) I'm failing to display something properly. - If you see ${field} in your text, if something is missing, if the spacing is weird, etc.
If you find an error, please tell me:
1) What the exact text was (if possible)
2) What color it should be (Grey, Yellow, etc.) if the color was wrong
3) If there's an error in the console, the exact line number and message.
These add_to_chat colors are blocked by battlemod:
These ones are blocked:
20,21,22,23,24,25,26,28,29,31,32,33,35,36,40,41,42,43,44,50,51,52,56,57,59,60,69,64,65,67,69,81,85,90,91,100,101,102,104,105,106,110,111,112,114,122,163,164,168,171,175,177,183,185,186,191
|
|